JoomDev: Version 1.1 : wrong CSS handling (1/1)

Trick or Treat - 30% OFF - Coupon Code: SCARY20 Download Now

Welcome, Guest

Version 1.1 : wrong CSS handling

TOPIC: Version 1.1 : wrong CSS handling

Version 1.1 : wrong CSS handling 1 month 2 weeks ago #24384

pmleconte
Offline
Junior Member
Posts: 22
Thank you received: 3
Karma: 0

After upgrading to 1.1 version, no size/color parameter are working.
In tmpl/default.php file : missing space in CSS definition causing wrong CSS handling.
In line 37, 41, 45,... there shoud be a space between

#skillset-<?php echo $module->id; ?>

and the class name.
For example,

#skillset-<?php echo $module->id; ?>.counter-number .count {

becomes

#skillset-<?php echo $module->id; ?> .counter-number .count {

, and so one for the eight classes/parameters..

The administrator has disabled public write access.

Version 1.1 : wrong CSS handling 1 month 1 week ago #24385

pmleconte
Offline
Junior Member
Posts: 22
Thank you received: 3
Karma: 0

For information, to solve upgrade issue www.joomdev.com/forum/jd-skillset/5305-s...-to-update-skill-set , you have to just move $doc & $params lines out of helper.php and copy them in mod_jd_skillset.php file.

I don't know why, but install process reads helper.php file, so $params is empty.

By the way, I think you won't need you helper.php file. So, mod_jd_skillset.php becomes :

<?php
/**
 * Helper class for Jd Skillset! module
 * @package     JD Skill Set
 * @copyright   Copyright (C) 2018 Joomdev, Inc. All rights reserved.
 * @license     GNU General Public License version 2 or later; see LICENSE
 */
// No direct access
defined('_JEXEC') or die;
// Style Sheet
$doc = JFactory::getDocument();
$doc->addStyleSheet(JURI::root().'media/mod_jd_skillset/css/mod_jd_skillset.css');
if($params->get('load_bootstrap', 1)){
	$doc->addStyleSheet('https://stackpath.bootstrapcdn.com/bootstrap/4.1.3/css/bootstrap.min.css');
}
if($params->get('load_fontawesome', 1)){
	$doc->addStyleSheet('https://use.fontawesome.com/releases/v5.3.1/css/all.css');
}
$layout = $params->get('layout', 'default');
require JModuleHelper::getLayoutPath('mod_jd_skillset', $layout);

and don't forget to delete <filename>helper.php</filename> line

The administrator has disabled public write access.

Version 1.1 : wrong CSS handling 1 month 1 week ago #24410

pmleconte Offline Junior Member Posts: 22 Thank you received: 3 Karma: 0	Well, version 1.2 still have CSS issue. About update, it's still not working even after removing lines from helper.php file because Joomla install component is loading helper.php before installing a module. The quick and dirty way to solve this is to install package instead of trying to update it.
	The administrator has disabled public write access.

Version 1.1 : wrong CSS handling 1 month 1 week ago #24413

nishtha Offline Moderator Posts: 1407 Thank you received: 136 Karma: 17	Hi, Yes please do not auto update this module right now, there is some issue with it. Install & download the package file manually. After installing v1.2 further future updates will be free from this error and then you can easily auto update it. Thanks, Nishtha
	Thank You, If you like our support and products, tweet us at joomdev and let the world know about it. To know more about products check out the their documentation. The administrator has disabled public write access.

Version 1.1 : wrong CSS handling 1 month 2 days ago #24739

chandandeep Offline Administrator Posts: 3837 Thank you received: 586 Karma: 99	Hello, Auto update issued fixed in previous version v1.2 and custom styling issue fixed in v1.3. Thanks for reporting and suggestions. Thanks, Chandan
	Thank You, If you like our support and products, tweet us at joomdev and let the world know about it. To know more about products check out the their documentation. The administrator has disabled public write access. The following user(s) said Thank You: pmleconte