fbpx

Astroid 2.4 Landed with Joomla 4 Compatibility Download Now

Welcome, Guest
Username: Password: Remember me
  • Page:
  • 1
  • 2

TOPIC: PHP 7.3 Error - it could be ‘break’ or ...

PHP 7.3 Error - it could be ‘break’ or ... 1 year 3 months ago #15978

  • nobicycle
  • nobicycle's Avatar
  • Offline
  • Junior Member
  • Posts: 29
  • Karma: 0
Hi,

There are a number of Helix based templates, JD Construct included, where the following PHP error occurs:

"it could be ‘break’ or it could be ‘continue 2’."

Php case statement has been changed under php7.3 To fix this, the developer needs to decide whether continue should be replaced with 'break' or 'continue 2'

This error occurs is several templates. Others include (second field is line number)
Consult:
/plugins/system/helix3/core/classes/menu.php |89
/plugins/acymailing/tagcontent/tagcontent.php|1228

Biz-one
and guerrilla.

Will you be testing your templates under php 7.3 soon?

I already raised a ticket for JD Consult but got no reply yet.

I do not want to create a posting for all these separate cases. is there an email I can use to send you my findings?

Regards



I am running :
PHP 7.3.6 (cli) (built: May 28 2019 16:47:07) ( NTS )
Last Edit: 1 year 3 months ago by nobicycle.
The administrator has disabled public write access.

PHP 7.3 Error - it could be ‘break’ or ... 1 year 3 months ago #15986

  • admin
  • admin's Avatar
  • Offline
  • Administrator
  • Posts: 4145
  • Thank you received: 607
  • Karma: 108
Hello,

Right now all the templates are compatible with 7.2 or below, we are actively working to make all of them work with 7.3 and will be releasing updates as they are available. unfortunately, I don't have a timeline on it yet but it will be done in the very near future.

My apologies for not being able to reply to your email ticket. It must have been lost within the gazillion email we get every day :).

Thanks,
Chetan
Thank You,
If you like our support and products, tweet us at joomdev and let the world know about it.
The administrator has disabled public write access.
The following user(s) said Thank You: nobicycle

PHP 7.3 Error - it could be ‘break’ or ... 1 year 3 months ago #15997

  • nobicycle
  • nobicycle's Avatar
  • Offline
  • Junior Member
  • Posts: 29
  • Karma: 0
Understood.
The administrator has disabled public write access.

PHP 7.3 Error - it could be ‘break’ or ... 1 year 1 month ago #17446

  • nobicycle
  • nobicycle's Avatar
  • Offline
  • Junior Member
  • Posts: 29
  • Karma: 0
May I politely remind Admin about Construct - it was the reason I subscribed.

I feel sure that when you look, it will only be a few lines to change - no need for a full overhaul. Publishing the changes needed here would be perfectly acceptable.
The administrator has disabled public write access.

PHP 7.3 Error - it could be ‘break’ or ... 1 year 1 month ago #17449

  • admin
  • admin's Avatar
  • Offline
  • Administrator
  • Posts: 4145
  • Thank you received: 607
  • Karma: 108
Hello,

The first error (related to the template can be fixed by replacing menu.php with the following file.
gist.github.com/chetanmadaan/20c907d87efd1f83e186a16014b97c38
/plugins/system/helix3/core/classes/

For the error #2, if you update and make sure you have the latest AcyMailing, that should fix as well.

Thanks,
Chetan
Thank You,
If you like our support and products, tweet us at joomdev and let the world know about it.
The administrator has disabled public write access.
The following user(s) said Thank You: nobicycle

PHP 7.3 Error - it could be ‘break’ or ... 1 year 1 month ago #17493

  • nobicycle
  • nobicycle's Avatar
  • Offline
  • Junior Member
  • Posts: 29
  • Karma: 0
Also to report is BizOne. After the same fix as Construct was applied, there are the following additional errors/ notices:

Notice: Undefined offset: 1 in /srv/http/bizone/templates/jd_biz_one/features/social.php on line 79

For the errors - see attached Nginx log.
Attachments:
The administrator has disabled public write access.

PHP 7.3 Error - it could be ‘break’ or ... 1 year 1 month ago #17503

  • chandandeep
  • chandandeep's Avatar
  • Offline
  • Administrator
  • Posts: 3816
  • Thank you received: 584
  • Karma: 99
Hello,

Are you using the custom social icon from the template settings? If yes, Make sure you are using the right syntax.
See the attachment.

Thanks,
Chandan
Attachments:
Thank You,
If you like our support and products, tweet us at joomdev and let the world know about it.

To know more about products check out the their documentation.
The administrator has disabled public write access.
The following user(s) said Thank You: nobicycle

PHP 7.3 Error - it could be ‘break’ or ... 1 year 1 month ago #17526

  • nobicycle
  • nobicycle's Avatar
  • Offline
  • Junior Member
  • Posts: 29
  • Karma: 0
I installed the quickstart only - no customization. However, when I looked 'fa-instagram' was present in the Custom field. Deleting that made the Notice go away.

Retesting raised more Notices

When clicking in the menu Video Slider or Static Banner
Notice: Undefined offset: 1 in /srv/http/bizone/templates/jd_biz_one/features/social.php on line 79
When clicking in the menu News
Notice: Undefined offset: 1 in /srv/http/bizone/templates/jd_biz_one/features/social.php on line 79

On the Home Page
Warning: count(): Parameter must be an array or an object that implements Countable in /srv/http/bizone/templates/jd_biz_one/html/mod_k2_content/Default/default.php on line 106

There are still a load or Errors in the nginx log (see attached)
Example:
2019/09/10 13:58:04 [error] 8869#8869: *1060 FastCGI sent in stderr: "PHP message: PHP Notice: Undefined offset: 1 in /srv/http/bizone/templates/jd_biz_one/features/social.php on line 79" while reading response header from upstream, client: 192.168.1.100, server: bizone.localdomain, request: "GET /index.php/news HTTP/1.1", upstream: "fastcgi://unix:/run/php-fpm/php-fpm.sock:", host: "bizone.localdomain", referrer: "bizone.localdomain/"
Attachments:
Last Edit: 1 year 1 month ago by nobicycle.
The administrator has disabled public write access.

PHP 7.3 Error - it could be ‘break’ or ... 1 year 1 month ago #17628

  • chandandeep
  • chandandeep's Avatar
  • Offline
  • Administrator
  • Posts: 3816
  • Thank you received: 584
  • Karma: 99
Hello

Sorry for the late reply.
The social icon issue will fix in the next update.

Remove the social icon issue from Video Slider or Static Banner menu item. You have to follow the same steps.
1. Go to Extensions > Templates > Styles
2. Open the jd_biz_one - Solid_Header template style from the list
3. Find SOCIAL ICONS in Basic tab and remove the custom icon or add the link with the icon.

On the Home Page
1. Open the Homepage Blog module.
2. Find Extra fields and select the hide options.
See the screenshot

Thanks,
Chandan
Attachments:
Thank You,
If you like our support and products, tweet us at joomdev and let the world know about it.

To know more about products check out the their documentation.
Last Edit: 1 year 1 month ago by chandandeep.
The administrator has disabled public write access.
The following user(s) said Thank You: nobicycle

PHP 7.3 Error - it could be ‘break’ or ... 1 year 3 weeks ago #17886

  • mce123
  • mce123's Avatar
  • Offline
  • Senior Member
  • Posts: 56
  • Thank you received: 1
  • Karma: 0
I have the same issue... I'll just use 7.2 for now.

The administrator has disabled public write access.
  • Page:
  • 1
  • 2
Moderators: chandandeep
Time to create page: 0.458 seconds
Cron Job Starts